[FFmpeg-devel] [PATCH] do not write empty udta atom

[Baptiste Coudurier]

Benoit Fouet wrote:
> Baptiste Coudurier wrote:
>> Benoit Fouet wrote:
>>   
>>> LIBAVFORMAT_IDENT is only written in MODE_MOV ATM, and if not in
>>> bitexact mode.
>>>     
>> It is also written in MODE_MP4 if any metadata is available, check
>> mov_write_ilst_tag.
>>
>>   
> 
> indeed, thanks
> 
>>> [...]
>>> +
>>> +    if (s->title[0]   || s->author[0] || s->album[0] || s->year ||
>>> +        s->comment[0] || s->genre[0]  || s->track ||
>>> +       (mov->mode == MODE_MOV &&
>>> +       (mov->tracks[0].enc && !mov->tracks[0].enc->flags & CODEC_FLAG_BITEXACT) || req)) {
>>>     
>> movenc.c:1238: warning: suggest parentheses around && within ||
>>
>>   
> 
> oops... not only the warning, but it was plain wrong :(
> updated (and i think last) patch attached.
> 

Looks ok, don't forget to reindent.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312