[FFmpeg-devel] [PATCH] do not write empty udta atom

[Benoit Fouet]

Baptiste Coudurier wrote:
> Benoit Fouet wrote:
>   
>> LIBAVFORMAT_IDENT is only written in MODE_MOV ATM, and if not in
>> bitexact mode.
>>     
>
> It is also written in MODE_MP4 if any metadata is available, check
> mov_write_ilst_tag.
>
>   

indeed, thanks

>> [...]
>> +
>> +    if (s->title[0]   || s->author[0] || s->album[0] || s->year ||
>> +        s->comment[0] || s->genre[0]  || s->track ||
>> +       (mov->mode == MODE_MOV &&
>> +       (mov->tracks[0].enc && !mov->tracks[0].enc->flags & CODEC_FLAG_BITEXACT) || req)) {
>>     
>
> movenc.c:1238: warning: suggest parentheses around && within ||
>
>   

oops... not only the warning, but it was plain wrong :(
updated (and i think last) patch attached.

-- 
Ben
Purple Labs S.A.
www.purplelabs.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: movenc.c.diff
Type: text/x-patch
Size: 1827 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071024/676da11b/attachment.bin>