[FFmpeg-devel] [PATCH] do not write empty udta atom

Baptiste Coudurier baptiste.coudurier
Wed Oct 24 11:15:28 CEST 2007


Hi Benoit,

Benoit Fouet wrote:
> Benoit Fouet wrote:
>> Baptiste Coudurier wrote:
>>   
>>> Benoit Fouet wrote:
>>>   
>>>     
>>>> Hi,
>>>>
>>>> ATM, movenc.c writes the udta atom even if it is empty.
>>>> this patch checks that we have something to write before writing the atom.
>>>>
>>>>     
>>>>       
>>> Why creating an empty atom for MODE_MOV ? Do it for all.
>>> You forgot the libavformat ident.
>>>   
>>>     
>> i also forgot the requirements... thanks for noticing
>> updated patch attached.
>>
>>   
> 
> ping ? Baptiste, Michael ?
> 

req is for MODE_MOV only and LIBAVFORMAT_IDENT is also written for mp4
currently.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312




More information about the ffmpeg-devel mailing list