[FFmpeg-devel] [PATCH] do not write empty udta atom

[Benoit Fouet]

Baptiste Coudurier wrote:
> Hi Benoit,
>
> Benoit Fouet wrote:
>   
>> Benoit Fouet wrote:
>>     
>>> Baptiste Coudurier wrote:
>>>   
>>>       
>>>> Benoit Fouet wrote:
>>>>   
>>>>     
>>>>         
>>>>> Hi,
>>>>>
>>>>> ATM, movenc.c writes the udta atom even if it is empty.
>>>>> this patch checks that we have something to write before writing the atom.
>>>>>
>>>>>     
>>>>>       
>>>>>           
>>>> Why creating an empty atom for MODE_MOV ? Do it for all.
>>>> You forgot the libavformat ident.
>>>>   
>>>>     
>>>>         
>>> i also forgot the requirements... thanks for noticing
>>> updated patch attached.
>>>
>>>   
>>>       
>> ping ? Baptiste, Michael ?
>>
>>     
>
> req is for MODE_MOV only and LIBAVFORMAT_IDENT is also written for mp4
> currently.
>   

at the moment, it is not, but this could be another patch...

-- 
Ben
Purple Labs S.A.
www.purplelabs.com