[FFmpeg-devel] [PATCH] faad2 version 2.5 support

[Dominik 'Rathann' Mierzejewski]

On Saturday, 06 October 2007 at 19:53, Frank Liu wrote:
> On 10/6/07, Dominik 'Rathann' Mierzejewski <dominik at rangers.eu.org> wrote:
> > > > Your FAAD2 has been patched not to include backward compatibility APIs.
> > > I can confirm that I did not patch
> > > FAAD2 yesterday when I built it. Besides, if the compatibility is
> > > removed, ffmpeg will not even compile.
> >
> > FFmpeg compiles here against faad2-2.5 without your patch just fine.
> 
> What I meant was if I had applied a patch to remove the compatibility
> APIs in FAAD2-2.5 as you suspected earlier, ffmpeg from svn wouldn't
> even compile. The fact that I was able to compile ffmpeg without any
> patch just fine means the FAAD2 does have the compatiblity API.

Have you checked that your FAAD was built from pristine source? Or are you
just guessing?

[...]
> > > > > I think your patch would break building of the older FAAD (FAAC?) versions.
> > > >
> > > > Indeed.
> > >
> > > Agree, we will need to do some chechkings in "configure" and some
> > > ifdefs in codes. My patch is just my quick way to get it work for FAAD
> > > 2.5.
> >
> > It's not necessary.
> 
> I agree it is not necessary if the compiled ffmpeg works like you
> posted earlier. But for some reasons, my ffmpeg gave errors as above.
> This is the whole reason I then patched the ffmpeg and recompiled it.
> This time, ffmpeg runs fine with no errors.
> Don't get me wrong,I really want to have an unpatched ffmpeg just works.
> Any thoughts?

I'm only guessing, but you might have a set of FAAD headers which defines
the old API functions, but the functions are not found in the library itself.
And since the libs are dlopen'd, the errors only occur at runtime.
Anyway, there seems to be a problem with your FAAD installation.

Besides, this is not ffmpeg-devel topic anymore, so let's stop here.

Regards,
R.

-- 
MPlayer developer and RPMs maintainer: http://mplayerhq.hu http://rpm.livna.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan