[FFmpeg-devel] [PATCH] faad2 version 2.5 support

[Frank Liu]

On 10/6/07, Dominik 'Rathann' Mierzejewski <dominik at rangers.eu.org> wrote:
> > > Your FAAD2 has been patched not to include backward compatibility APIs.
> > I can confirm that I did not patch
> > FAAD2 yesterday when I built it. Besides, if the compatibility is
> > removed, ffmpeg will not even compile.
>
> FFmpeg compiles here against faad2-2.5 without your patch just fine.

What I meant was if I had applied a patch to remove the compatibility
APIs in FAAD2-2.5 as you suspected earlier, ffmpeg from svn wouldn't
even compile. The fact that I was able to compile ffmpeg without any
patch just fine means the FAAD2 does have the compatiblity API.  But
unfortunately, the compiled ffmpeg binary runs with errors:

ffmpeg -i raj.mp4  -ar 22050 -f flv -y test.flv
FFmpeg version SVN-r10671, Copyright (c) 2000-2007 Fabrice Bellard, et al.
 configuration: --enable-libmp3lame --enable-libogg
--enable-libvorbis --enable-libfaad --enable-libfaadbin
--enable-libfaac --enable-gpl
 libavutil version: 49.5.0
 libavcodec version: 51.44.0
 libavformat version: 51.14.0
 built on Oct  5 2007 23:37:18, gcc: 4.1.1 20070105 (Red Hat 4.1.1-52)
[mpeg4aac @ 0x84b60d0]FAAD library: cannot resolve
faacDecGetErrorMessage in libfaad.so.0!
[mpeg4aac @ 0x84b60d0]FAAD library: cannot resolve
faacDecGetErrorMessage in libfaad.so.0!
...
[mpeg4aac @ 0x84b60d0]FAAD library: cannot resolve
faacDecGetErrorMessage in libfaad.so.0!
[mov,mp4,m4a,3gp,3g2,mj2 @ 0x840aa74]Could not find codec parameters
(Audio: mpeg4aac)

Seems stream 0 codec frame rate differs from container frame rate:
1000.00 (1000/1) -> 15.00 (15/1)
Input #0, mov,mp4,m4a,3gp,3g2,mj2, from 'raj.mp4':
 Duration: 00:00:09.5, start: 0.000000, bitrate: 808 kb/s
 Stream #0.0(und): Video: mpeg4, yuv420p, 320x240, 15.00 fps(r)
 Stream #0.1(und): Audio: mpeg4aac
Output #0, flv, to 'test.flv':
 Stream #0.0(und): Video: flv, yuv420p, 320x240, q=2-31, 200 kb/s, 15.00 fps(c)
 Stream #0.1(und): Audio: libmp3lame, 22050 Hz, mono, 64 kb/s
Stream mapping:
 Stream #0.0 -> #0.0
 Stream #0.1 -> #0.1
[mpeg4aac @ 0x84b60d0]FAAD library: cannot resolve
faacDecGetErrorMessage in libfaad.so.0!
Error while opening codec for input stream #0.1

>
> > > > I think your patch would break building of the older FAAD (FAAC?) versions.
> > >
> > > Indeed.
> >
> > Agree, we will need to do some chechkings in "configure" and some
> > ifdefs in codes. My patch is just my quick way to get it work for FAAD
> > 2.5.
>
> It's not necessary.

I agree it is not necessary if the compiled ffmpeg works like you
posted earlier. But for some reasons, my ffmpeg gave errors as above.
This is the whole reason I then patched the ffmpeg and recompiled it.
This time, ffmpeg runs fine with no errors.
Don't get me wrong,I really want to have an unpatched ffmpeg just works.
Any thoughts?

Thanks!
Frank