[FFmpeg-devel] [PATCH] faad2 version 2.5 support

[Dominik 'Rathann' Mierzejewski]

On Saturday, 06 October 2007 at 18:06, Frank Liu wrote:
> On 10/6/07, Dominik 'Rathann' Mierzejewski <dominik at rangers.eu.org> wrote:
> > On Saturday, 06 October 2007 at 02:01, Ivan Kalvachev wrote:
> > > 2007/10/6, Frank Liu <gfrankliu at gmail.com>:
> > > [...]
> > > >
> > > > If I apply my patch and rebuild ffmpeg, same command runs without any errors.
> > > >
> > > > Thoughts?
> >
> > Your FAAD2 has been patched not to include backward compatibility APIs.
> 
> Hi Dominik,
> Can you please try the same mp4 file and run the command on your
> system, and post the result back?

Works fine:
$ ffmpeg -i raj.mp4  -ar 22050 -f flv -y test.flv
FFmpeg version SVN-r10550, Copyright (c) 2000-2007 Fabrice Bellard, et al.
  configuration: --prefix=/usr --incdir=/usr/include/ffmpeg --libdir=/usr/lib64 --shlibdir=/usr/lib64 --mandir=/usr/share/man --arch=x86_64 --extra-cflags=-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic --enable-liba52bin --enable-libfaac --enable-libfaad --enable-libgsm --enable-libmp3lame --enable-libogg --enable-libtheora --enable-libvorbis --enable-libxvid --enable-libx264 --enable-pp --enable-pthreads --disable-static --enable-shared --enable-gpl --disable-debug --disable-opts --disable-strip
  libavutil version: 49.5.0
  libavcodec version: 51.44.0
  libavformat version: 51.13.4
  built on Sep 23 2007 16:04:34, gcc: 4.1.2 20070502 (Red Hat 4.1.2-12)

Seems stream 0 codec frame rate differs from container frame rate: 1000.00 (1000/1) -> 14.99 (15000/1001)
Input #0, mov,mp4,m4a,3gp,3g2,mj2, from 'raj.mp4':
  Duration: 00:00:09.5, start: 0.000000, bitrate: 808 kb/s
  Stream #0.0(und): Video: mpeg4, yuv420p, 320x240, 14.99 fps(r)
  Stream #0.1(und): Audio: mpeg4aac, 48000 Hz, stereo
Output #0, flv, to 'test.flv':
  Stream #0.0(und): Video: flv, yuv420p, 320x240, q=2-31, 200 kb/s, 14.99 fps(c)
  Stream #0.1(und): Audio: libmp3lame, 22050 Hz, stereo, 64 kb/s
Stream mapping:
  Stream #0.0 -> #0.0
  Stream #0.1 -> #0.1
Press [q] to stop encoding
frame=  144 fps=137 q=5.5 Lsize=     479kB time=9.1 bitrate= 430.6kbits/s    
video:400kB audio:71kB global headers:0kB muxing overhead 1.690841%

> I can confirm that I did not patch
> FAAD2 yesterday when I built it. Besides, if the compatibility is
> removed, ffmpeg will not even compile.

FFmpeg compiles here against faad2-2.5 without your patch just fine.

> > > I think your patch would break building of the older FAAD (FAAC?) versions.
> >
> > Indeed.
> 
> Agree, we will need to do some chechkings in "configure" and some
> ifdefs in codes. My patch is just my quick way to get it work for FAAD
> 2.5.

It's not necessary.

Regards,
R.

-- 
MPlayer developer and RPMs maintainer: http://mplayerhq.hu http://rpm.livna.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan