[FFmpeg-devel] libavutil simd

[Diego Biurrun]

On Tue, Oct 02, 2007 at 01:19:12PM +0200, Luca Barbato wrote:
> Diego Biurrun wrote:
> > On Tue, Oct 02, 2007 at 12:36:21PM +0200, Luca Barbato wrote:
> >> here the patch, it works fine for ppc, Diego have a look at the Makefile
> >> changes.
> >>
> >> check_altivec.c MUST BE BUILT w/out -maltivec
> > 
> > That can be achieved without such a lot of Makefile hackery, for example
> > with something like (untested):
> > 
> > ppc/check_altivec.o: CFLAGS := $(filter-out -maltivec,$(CFLAGS))
> 
> The rest must have -maltivec -mabi=altivec on...

Yes, but you still have the logic backwards, that's why your patch is so
intrusive.  Just turn it off for the one file that does not need it.

> >> --- ppc/imgresample_altivec.h	(revision 0)
> >> +++ ppc/imgresample_altivec.h	(revision 0)
> >> @@ -0,0 +1,26 @@
> >> +/*
> >> + * Copyright (c) 2001 Fabrice Bellard. 
> > 
> > trailing whitespace
> > 
> > Also, is Fabrice the author of this code?  I don't think so, just remove
> > the line.
> 
> The unsplitted source header got preserved...

The source header is not a copyrightable work.

Diego