[FFmpeg-devel] libavutil simd

[Luca Barbato]

Diego Biurrun wrote:
> On Tue, Oct 02, 2007 at 12:36:21PM +0200, Luca Barbato wrote:
>> here the patch, it works fine for ppc, Diego have a look at the Makefile
>> changes.
>>
>> check_altivec.c MUST BE BUILT w/out -maltivec
> 
> That can be achieved without such a lot of Makefile hackery, for example
> with something like (untested):
> 
> ppc/check_altivec.o: CFLAGS := $(filter-out -maltivec,$(CFLAGS))

The rest must have -maltivec -mabi=altivec on...

> 
> An appropriate comment would also be useful.
> 
>> --- ppc/imgresample_altivec.c	(revision 10492)
>> +++ ppc/imgresample_altivec.c	(working copy)
>> @@ -20,268 +20,12 @@
>>  
>>  /**
>> - * @file imgresample.c
>> - * High quality image resampling with polyphase filters .
>> + * @file imgresample_altivec.c
>> + * High quality image resampling with polyphase filters - altivec bits
>>   */
> 
> Should be good to commit right away, but please spell AltiVec correctly.

ok

> 
>> --- ppc/imgresample_altivec.h	(revision 0)
>> +++ ppc/imgresample_altivec.h	(revision 0)
>> @@ -0,0 +1,26 @@
>> +/*
>> + * Copyright (c) 2001 Fabrice Bellard. 
> 
> trailing whitespace
> 
> Also, is Fabrice the author of this code?  I don't think so, just remove
> the line.

The unsplitted source header got preserved...

lu

-- 

Luca Barbato

Gentoo/linux Gentoo/PPC
http://dev.gentoo.org/~lu_zero