[FFmpeg-devel] [PATCH] MLP/TrueHD decoder

Ian Caulfield ian.caulfield
Mon Nov 19 11:02:19 CET 2007


Hi

On Nov 19, 2007 1:26 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
>
> On Sun, Nov 18, 2007 at 08:58:05PM +0000, Ian Caulfield wrote:
> > On Nov 18, 2007 4:43 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > >
> > > > +
> > > > +        ff_combine_frame(&mp->pc, i - 7, &buf, &buf_size);
> > > > +
> > > > +        return FFMAX(i - 7, 0);
> > >
> > > i think this should be return i-7
> >
> > Is it valid to return a negative number in a non-error case?
>
> the code which calls it says:
>
>     /* WARNING: the returned index can be negative */
>     index = s->parser->parser_parse(s, avctx, (const uint8_t **)poutbuf, poutbuf_size, buf, buf_size);

Fair enough, updated patch attached.

Ian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mlp_parse.patch
Type: text/x-diff
Size: 12658 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071119/b440b151/attachment.patch>



More information about the ffmpeg-devel mailing list