[FFmpeg-devel] [PATCH] MLP/TrueHD decoder

Michael Niedermayer michaelni
Mon Nov 19 02:26:42 CET 2007


Hi
On Sun, Nov 18, 2007 at 08:58:05PM +0000, Ian Caulfield wrote:
> On Nov 18, 2007 4:43 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >
> > > +
> > > +        ff_combine_frame(&mp->pc, i - 7, &buf, &buf_size);
> > > +
> > > +        return FFMAX(i - 7, 0);
> >
> > i think this should be return i-7
> 
> Is it valid to return a negative number in a non-error case?

the code which calls it says:

    /* WARNING: the returned index can be negative */
    index = s->parser->parser_parse(s, avctx, (const uint8_t **)poutbuf, poutbuf_size, buf, buf_size);

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071119/8fe7ab14/attachment.pgp>



More information about the ffmpeg-devel mailing list