[FFmpeg-devel] [PATCH] TXD demuxer and decoder

Ivo ivop
Mon May 7 15:35:57 CEST 2007


On Sunday 06 May 2007 22:34, Michael Niedermayer wrote:
> On Sun, May 06, 2007 at 09:44:36PM +0200, Ivo wrote:
> > Ok, I stripped down the demuxer to its bare bones and it still demuxes
> > the same GTA:SA files as it did before. I also added PAL8 and raw RGB32
> > support to the decoder and fixed a bug in the decoder. The patch also
> > includes all your previous suggestions that I did not send to the list
> > yet.
>
> > +    for (by=0; by < h/4; by++, d += stride-w)
> > +        for (bx=0; bx < w/4; bx++, s+=16, d+=4)
> > +            dxt1_decode_pixels(s+8, d, qstride, 1, le2me_64(*(uint64_t
> > *)s));
>
> i think s will not be aligned to 8 bytes here so this could crash non x86
>
> except that iam fine with the patch

Applied with le2me_64 changed to AV_RL64.

BTW shouldn't I replace le2me_{16,32} by AV_RL{16,32} too?

--Ivo




More information about the ffmpeg-devel mailing list