[FFmpeg-devel] [PATCH] TXD demuxer and decoder

[Michael Niedermayer]

Hi

On Mon, May 07, 2007 at 03:35:57PM +0200, Ivo wrote:
> On Sunday 06 May 2007 22:34, Michael Niedermayer wrote:
> > On Sun, May 06, 2007 at 09:44:36PM +0200, Ivo wrote:
> > > Ok, I stripped down the demuxer to its bare bones and it still demuxes
> > > the same GTA:SA files as it did before. I also added PAL8 and raw RGB32
> > > support to the decoder and fixed a bug in the decoder. The patch also
> > > includes all your previous suggestions that I did not send to the list
> > > yet.
> >
> > > +    for (by=0; by < h/4; by++, d += stride-w)
> > > +        for (bx=0; bx < w/4; bx++, s+=16, d+=4)
> > > +            dxt1_decode_pixels(s+8, d, qstride, 1, le2me_64(*(uint64_t
> > > *)s));
> >
> > i think s will not be aligned to 8 bytes here so this could crash non x86
> >
> > except that iam fine with the patch
> 
> Applied with le2me_64 changed to AV_RL64.
> 
> BTW shouldn't I replace le2me_{16,32} by AV_RL{16,32} too?

if they are guaranteed to be aligned (i think so IIRC) then the le2me()
can stay, it might be faster (or maybe not but i guess benchmarking this
on several arhcitectures (on x86 they should be the same) isnt worth it ...)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070507/f25c64a3/attachment.pgp>