[FFmpeg-devel] [PATCH] h264 luma interpolation 8x8 for altivec

[Luca Barbato]

Mauricio Alvarez wrote:
> part1: cosmetics: replace all the variable definitions in h264_altivec.c
> and
> h264_template_altivec.c with the data types defined in types_altivec.h
> including the use of the LOAD_ZERO and the corresponding zero_xxxxv
> definitions.

Seems ok

> part2: removes alignment correction of the destination pointers in
> luma_16x6
> interpolations. As I mentioned before I have made a test and these pointers
> are always aligned to 128-bit- The only source of misalignment (with
> respect
> to 128-bit) is the variable block size, but in the 16x16 case the
> destination is always aligned.

Ok

> 
> part3. add luma_8x8 interpolation routines. I made a complete patch for
> this.  This functions are very similar to the 16x16 ones, but taking into
> account the alignment of the 8x8 cases and other minor details.


Please add a comment just in case. It's unlikely that we'd have cpus
with VMX with larger vectors but better be safe.

part3 Ok

part4 Seems ok, maybe make it fit 79cols

That's all from a quick read of the code, I'll test it soon.

lu

-- 

Luca Barbato

Gentoo/linux Gentoo/PPC
http://dev.gentoo.org/~lu_zero