[FFmpeg-devel] [PATCH] h264 luma interpolation 8x8 for altivec

[Guillaume Poirier]

Hi,

I'd prefer if all comments on top of the functions could match the
name of the parameters:

Mauricio Alvarez wrote:

> --- libavcodec/ppc/h264_template_altivec.c	2007-06-26 12:30:40.000000000 +0200
> +++ /home/alvarez/turandot_simulation/media_tools/src/ffmpeg/libavcodec/ppc/h264_template_altivec.c	2007-06-26 12:10:24.000000000 +0200
> @@ -634,3 +634,413 @@ static void PREFIX_h264_qpel16_hv_lowpas
>    }
>    POWERPC_PERF_STOP_COUNT(PREFIX_h264_qpel16_hv_lowpass_num, 1);
>  }
> +
> +/* this code assumes stride % 16 == 0 and dst is aligned to 64 bits */
> +static void PREFIX_h264_qpel8_h_lowpass_altivec(uint8_t * dst, uint8_t * src, int dstStride, int srcStride) {

Does that mean that both dstStride and srcStride need to ensure % 16
== 0? It's better if you specify it.


> +/* this code assume stride % 16 == 0 and and dst is aligned to 64 bits */
> +static void PREFIX_h264_qpel8_v_lowpass_altivec(uint8_t * dst, uint8_t * src, int dstStride, int srcStride) {

here too


> +/* this code assume stride % 16 == 0 *and* tmp is properly aligned *and* dst is aligned to 64-bits */
> +static void PREFIX_h264_qpel8_hv_lowpass_altivec(uint8_t * dst, int16_t * tmp, uint8_t * src, int dstStride, int tmpStride, int srcStride) {

and here.... note that this time there's 3 strides

Guillaume