[FFmpeg-devel] sdp.c and CONFIG_RTP_MUXER

[Luca Abeni]

Hi Michael,

On Tue, 2007-07-31 at 11:49 +0200, Michael Niedermayer wrote:
[...]
> > >  isn't it better to use ?
> > > #ifdef ENABLE_RTP_MUXER
> > > {
> > >  ...
> > > }
> > > #else
> > >   return NULL;
> > > #endif
> > 
> > This was my first try... It works, but it generates warnings because
> > some static functions are defined but not used in sdp.c. But I am ok
> > with this version too, if it is preferred.
> 
> i prefer the #ifdef over if() as later is just not correct its pure luck
> that it works
> also here theres no difference in complexity, the if() is not simpler

Ok, I'll prepare a patch using #ifdef (I will need to #ifdef out all the
static functions to avoid warnings), and I'll send it later.


			Thanks,
				Luca