[FFmpeg-devel] sdp.c and CONFIG_RTP_MUXER

[Michael Niedermayer]

Hi

On Tue, Jul 31, 2007 at 01:05:45PM +0200, Luca Abeni wrote:
> Hi Michael,
> 
> On Tue, 2007-07-31 at 11:49 +0200, Michael Niedermayer wrote:
> [...]
> > > >  isn't it better to use ?
> > > > #ifdef ENABLE_RTP_MUXER
> > > > {
> > > >  ...
> > > > }
> > > > #else
> > > >   return NULL;
> > > > #endif
> > > 
> > > This was my first try... It works, but it generates warnings because
> > > some static functions are defined but not used in sdp.c. But I am ok
> > > with this version too, if it is preferred.
> > 
> > i prefer the #ifdef over if() as later is just not correct its pure luck
> > that it works
> > also here theres no difference in complexity, the if() is not simpler
> 
> Ok, I'll prepare a patch using #ifdef (I will need to #ifdef out all the
> static functions to avoid warnings), and I'll send it later.

no, i wont accept #ifdef hell to supress warnings!

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070731/739c45dd/attachment.pgp>