[FFmpeg-devel] [PATCH] Move H.264 DSP functions from dsputil.c to h264dsp.c

[Michael Niedermayer]

Hi

On Sat, Jul 28, 2007 at 01:12:28PM +0200, Panagiotis Issaris wrote:
> Hi,
> 
> Panagiotis Issaris wrote:
> > [...]
> >   
> > Next, the attached patch moves the H.264 decoder DSP functions out of
> > dsputil into a separate file called h264dspdec.c.
> > Tested with ./configure --enable-gpl and ./configure --enable-gpl --disable-decoder=h264
> >
> >  Makefile     |    2
> >  dsputil.c    |  321 -----------------------------------------------------
> >  h264dspdec.c |  355 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 360 insertions(+), 318 deletions(-)
> >
> >
> >   
> 
> Oh yes, for the header of h264dspdec.c I took the dsputil.c header and
> gave it a more descriptive and specific title.
> 
> One thing I wasn't sure about though was  the statement regarding
> the author of gmc & qpel as no qpel or gmc code (being Michael Niedermayer).
> 
> Michael: As I haven't moved qpel or gmc code to h264dspdec.c I did not
> copy that
> statement to h264dspdec.c. Was that the right choice?

the statement was just about mpeg4 asp stuff
and i think that none of the h264 code was touched by fabrice ...


> 
> And a question for an upcoming patch moving qpel H.264 code: Was that
> qpel statement
> about all qpel code, all but h264 qpel code or only the h264 qpel code?
> 
> Furthermore, the header of dsputil.c and so also h264dspdec.c has
> copyright notices for 2000-2004
> but nothing is mentioned after that period. Maybe it's better to extend
> it to 2007?

yes, maybe

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070728/9e9e1fb2/attachment.pgp>