[FFmpeg-devel] [PATCH] Move H.264 DSP functions from dsputil.c to h264dsp.c

[Panagiotis Issaris]

Hi,

Panagiotis Issaris wrote:
> [...]
>   
> Next, the attached patch moves the H.264 decoder DSP functions out of
> dsputil into a separate file called h264dspdec.c.
> Tested with ./configure --enable-gpl and ./configure --enable-gpl --disable-decoder=h264
>
>  Makefile     |    2
>  dsputil.c    |  321 -----------------------------------------------------
>  h264dspdec.c |  355 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 360 insertions(+), 318 deletions(-)
>
>
>   

Oh yes, for the header of h264dspdec.c I took the dsputil.c header and
gave it a more descriptive and specific title.

One thing I wasn't sure about though was  the statement regarding
the author of gmc & qpel as no qpel or gmc code (being Michael Niedermayer).

Michael: As I haven't moved qpel or gmc code to h264dspdec.c I did not
copy that
statement to h264dspdec.c. Was that the right choice?

And a question for an upcoming patch moving qpel H.264 code: Was that
qpel statement
about all qpel code, all but h264 qpel code or only the h264 qpel code?

Furthermore, the header of dsputil.c and so also h264dspdec.c has
copyright notices for 2000-2004
but nothing is mentioned after that period. Maybe it's better to extend
it to 2007?

> diff --git a/libavcodec/h264dspdec.c b/libavcodec/h264dspdec.c
> new file mode 100644
> index 0000000..887aec9
> --- /dev/null
> +++ b/libavcodec/h264dspdec.c
> @@ -0,0 +1,355 @@
> +/*
> + * H.264/MPEG-4 Part 10 decoder DSP utils
> + * Copyright (c) 2000, 2001 Fabrice Bellard.
> + * Copyright (c) 2002-2004 Michael Niedermayer <michaelni at gmx.at>
> + *
> + * This file is part of FFmpeg.
> + *
> + * FFmpeg is free software; you can redistribute it and/or
> [...]
>   

With friendly regards,
Takis