[FFmpeg-devel] [RFC] move wmv2.c to its own file

[Diego Biurrun]

I found a moment to look into this again today..

On Sat, May 19, 2007 at 01:15:57AM +0200, Aurelien Jacobs wrote:
> On Fri, 18 May 2007 11:46:40 +0200
> Diego Biurrun <diego at biurrun.de> wrote:
> 
> > On Fri, May 11, 2007 at 11:35:29PM +0200, Diego Biurrun wrote:
> > > This is a rough draft for moving wmv2.c to its own file, i.e. make it
> > > not be just an include from msmpeg4.c[1].
> > 
> > Here is the second try.  Unfortunately the patch is starting to become
> > large and the resulting libavcodec.a is about 100k bigger than the
> > original.  I'm sure you guys can tell me how to avoid this...
> 
> You include msmpeg4tab.h in msmpeg4.h which is then included both
> in msmpeg4.c and wmv2.c. This duplicates the static tables in the
> 2 objects.
> msmpeg4tab.h *must* only be included from a single .c file.
> Tables which needs to be shared between the 2 .c files *must*
> be moved to msmpeg4data.c.
> This should solve the libavcodec.a size increase.

Is there a (good) reason to keep any of those tables in msmpeg4tab.h?
What about moving them all to msmpeg4data.c?

Diego