[FFmpeg-devel] [PATCH] RTSP multicast fix

[Michael Niedermayer]

Hi

On Thu, Jul 12, 2007 at 09:25:17PM +0200, Thijs Vermeir wrote:
> Hi
> 
> On Thu Jul 12 16:35:55 CEST 2007, Michael Niedermayer wrote :
> 
> >>Index: libavformat/rtsp.c
> >>>===================================================================
> >>--- libavformat/rtsp.c	(revision 9556)
> >>+++ libavformat/rtsp.c	(working copy)
> >>@@ -967,7 +967,7 @@
> >>                 av_strlcat(transport, ",", sizeof(transport));
> >>             snprintf(transport + strlen(transport),
> >>                      sizeof(transport) - strlen(transport) - 1,
> >>-                     "RTP/AVP/UDP;multicast");
> >>+                     "RTP/AVP;multicast");
> >>         }
> >
> >why is this needed?
> 
> in the rfc that describes this SDP protocol [1] RTP/AVP/UDP is only
> for unicast streams, RTP/AVP must be used for multicast streams. (also
> in the examples in the RFC for RTSP [2] page 66)

[1] does not specify anything but "RTP/AVP" and "udp" i see no relation
to multi vs. unicast
[2] does specifiy RTP/AVP[/lower-transport] where later defaults to udp it
does not seem to forbid to specify udp

so i cant see any mulitcast but not unicast MUST relation to RTP/AVP
it either seems always or never required


> 
> >...
> >ttl looks unused after this change
> Now it usses the ttl value announced in the SDP messages.

it already did before, now it just has a extra unused variable


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070712/9e887661/attachment.pgp>