[FFmpeg-devel] [PATCH] move av_codec_get_tag to libavformat/utils.c

[Måns Rullgård]

Michael Niedermayer wrote:
> Hi
>
> On Wed, Jul 11, 2007 at 01:07:56PM +0200, Aurelien Jacobs wrote:
>> On Wed, 11 Jul 2007 11:21:06 +0100 (BST)
>> M?ns Rullg?rd <mans at mansr.com> wrote:
>>
>> > Aurelien Jacobs wrote:
>> > > Hi,
>> > >
>> > > Currently, compilation of libavformat fails when configured with the
>> > > following parameters:
>> > >
>> > > ./configure --disable-muxers --disable-parsers --disable-demuxers
>> > > --disable-encoders --disable-decoders --disable-bsfs
>> > >
>> > > Here is the error:
>> > >
>> > > libavformat/libavformat.a(utils.o): In function `av_write_header':
>> > > libavformat/utils.c:2093: undefined reference to `av_codec_get_tag'
>> > >
>> > > av_codec_get_tag() is defined in riff.c which is compiled conditionally.
>> > > This is wrong anyway. A function which is part of public API must
>> > > be included un-conditionally.
>> > >
>> > > Solution 1: move av_codec_get_tag() into utils.c (see attached patch)
>> > > Is it OK ?
>> >
>> > If av_codec_get_tag() is moved, av_codec_get_id() should move too.  Also,
>> > Michael has previously said that AVCodecTag should be publicly opaque.
>>
>> OK. Attached patch should be better.
>
> looks ok

It doesn't make much sense to have the AVCodecTag definition in riff.h.
That file (along with riff.c) is meant for stuff specific to the RIFF
based formats.  AVCodecTag is used everywhere, so does not belong there
at all.  Is there no other place we can keep it?  If not, perhaps it's
time we made one.

-- 
M?ns Rullg?rd
mans at mansr.com