[FFmpeg-devel] [PATCH] move av_codec_get_tag to libavformat/utils.c

[Michael Niedermayer]

Hi

On Wed, Jul 11, 2007 at 01:07:56PM +0200, Aurelien Jacobs wrote:
> On Wed, 11 Jul 2007 11:21:06 +0100 (BST)
> M?ns Rullg?rd <mans at mansr.com> wrote:
> 
> > Aurelien Jacobs wrote:
> > > Hi,
> > >
> > > Currently, compilation of libavformat fails when configured with the
> > > following parameters:
> > >
> > > ./configure --disable-muxers --disable-parsers --disable-demuxers
> > > --disable-encoders --disable-decoders --disable-bsfs
> > >
> > > Here is the error:
> > >
> > > libavformat/libavformat.a(utils.o): In function `av_write_header':
> > > libavformat/utils.c:2093: undefined reference to `av_codec_get_tag'
> > >
> > > av_codec_get_tag() is defined in riff.c which is compiled conditionally.
> > > This is wrong anyway. A function which is part of public API must
> > > be included un-conditionally.
> > >
> > > Solution 1: move av_codec_get_tag() into utils.c (see attached patch)
> > > Is it OK ?
> > 
> > If av_codec_get_tag() is moved, av_codec_get_id() should move too.  Also,
> > Michael has previously said that AVCodecTag should be publicly opaque.
> 
> OK. Attached patch should be better.

looks ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070711/d8ddc5a8/attachment.pgp>