[FFmpeg-devel] [PATCH] matroska subtitle tracks support

[Aurelien Jacobs]

On Mon, 09 Jul 2007 22:16:31 +0100
M?ns Rullg?rd <mans at mansr.com> wrote:

> Aurelien Jacobs <aurel at gnuage.org> writes:
> 
> > On Mon, 9 Jul 2007 18:22:18 +0200
> > Michael Niedermayer <michaelni at gmx.at> wrote:
> >
> >> Hi
> >> 
> >> On Mon, Jul 09, 2007 at 03:47:21PM +0200, Aurelien Jacobs wrote:
> >> > Hi,
> >> > 
> >> > I want to apply the attached patch which provide support for Matroska
> >> > subtitle tracks.
> >> > Before applying it I wanted to be sure if it is OK to add
> >> > CODEC_ID_TEXT_SUBTITLE ?
> >> 
> >> what is TEXT ?
> >> is it raw  ASCII? raw UTF8? raw plain text (with some encoding specified
> >> somehow)?
> >
> > I intended it to be raw UTF8, but that indeed needs to be clarified.
> > CODEC_ID_TEXT_UTF8_SUBTITLE seems clear enough to me. OK ?
> 
> I can't say I like it.  What we need is something analogous to
> PixelFormat for text.

In some way, I think the idea is quite good. But on the other hand,
I wonder if it's a good idea to support anything else than UTF8 encoding ?
I think it would be better if all the text that goes out of libav* would
be UTF8.
But I guess depending on iconv or anything similar is not acceptable.

Well, I'm not sure what to do about this.
Any other opinion ?

Aurel