[Ffmpeg-devel] [PATCH]Update Doxygen comments for libavutil/tree.h

Måns Rullgård mans
Mon Feb 26 22:47:27 CET 2007


Trent Piepho <xyzzy at speakeasy.org> writes:

> On Mon, 26 Feb 2007, Dujardin Bernard wrote:
>> >
>> I did only little corrections :
>> if an insertion happened, then either key or NULL is returned (which it is
>> depends on the tree state and the implementation, you should make no
>> assumption that it is one or the other in the code)
>
> Since everyone else is offering...
>
>     If an insertion happened, then either key or NULL will be returned.
>     Which one depends on the tree state and the implementation, you should
>     not assume that it is one or the other.

The last sentence should be split at the comma.  Replacing the comma
with a semicolon would also do.

> It has been a long time since I learned this stuff, but I don't think
> "NULL is returned" is correct.  What tense is "is returned" supposed to
> be?

That would be the present simple tense.  It is the same form as "the
car is driven".

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-devel mailing list