[Ffmpeg-devel] [PATCH]Update Doxygen comments for libavutil/tree.h

Trent Piepho xyzzy
Mon Feb 26 23:56:22 CET 2007


On Mon, 26 Feb 2007, [iso-8859-1] M?ns Rullg?rd wrote:
> Trent Piepho <xyzzy at speakeasy.org> writes:
>
> > On Mon, 26 Feb 2007, Dujardin Bernard wrote:
> >> >
> >> I did only little corrections :
> >> if an insertion happened, then either key or NULL is returned (which it is
> >> depends on the tree state and the implementation, you should make no
> >> assumption that it is one or the other in the code)
> >
> > Since everyone else is offering...
> >
> >     If an insertion happened, then either key or NULL will be returned.
> >     Which one depends on the tree state and the implementation, you should
> >     not assume that it is one or the other.
>
> The last sentence should be split at the comma.  Replacing the comma
> with a semicolon would also do.

Yes.  You are right about that.

> > It has been a long time since I learned this stuff, but I don't think
> > "NULL is returned" is correct.  What tense is "is returned" supposed to
> > be?
>
> That would be the present simple tense.  It is the same form as "the
> car is driven".

Or is "returned" in "NULL is returned." acting as a participial adjective?
For example, in "The car is damaged," the word damaged is not functioning
as a verb, but as an adjective.

I guess if you say, "NULL is returned by the function," then clearly "is
retruned" is a verb in the present simple tense and the passive voice.

Still, using the present simple after an if clause seems wrong to me.




More information about the ffmpeg-devel mailing list