[Ffmpeg-devel] [PATCH] updated LGPL AC-3 decoder

Aurelien Jacobs aurel
Sat Feb 10 16:27:51 CET 2007


On Sat, 10 Feb 2007 15:44:14 +0100
Diego Biurrun <diego at biurrun.de> wrote:

> On Sat, Feb 10, 2007 at 01:17:52AM -0500, Justin Ruggles wrote:
> > I just realized I forgot to ask something I've been meaning to bring up.
> >  Does the old, unused ac3dec.c need to be kept around for archival
> > reasons or can it be reused/patched-over for the LGPL decoder instead of
> > using a name like ac3_decoder.c?
> 
> For consistency reasons I would prefer to reuse the old name.

Agree.

> Maybe we can rename the file to libac3dec.c first or something.

AFAICT ac3dec.c is currently unused (there is no Makefile rule to
build it). So I guess it can safely be removed.
I vote for removing it right now.

> Another thing that needs to be decided is what to do with the internal
> liba52 copy.  I vote for removing it right away, the external one works
> and we will have a native decoder in the near future.

Agree.
And IMO, we should even aim at removing external liba52 support (when
native ac3 support will be fully functionnal and well tested).

Aurel




More information about the ffmpeg-devel mailing list