[FFmpeg-devel] [PATCH] fix asf stream start_time and duration

[Michael Niedermayer]

Hi

On Wed, Aug 22, 2007 at 04:26:21PM +0200, Bj?rn Axelsson wrote:
> Second try getting this right...
> 
> This patch sets the start_time of each substream of an ASF file so that
> av_find_stream_info() can calculate the duration.

rejected, please give up there is NO BUG in asf.c related to start_time
your patches just revert bugfixes

(just because a light bulb isnt on doesnt mean the light bulb is at fault
yeah it could be that the light isnt switched on
just because you see a bug with one asf file does not mean the asf demuxer
is buggy, the same is true for all these idiots who report bugs with flv
its practically never related to any flv specific code)

the documentation even says:
    /**
     * decoding: pts of the first frame of the stream, in stream time base.
     * only set this if you are absolutely 100% sure that the value you set
                                ^^^^^^^^^^^^^^^^^^^^
     * it to really is the pts of the first frame
     * This may be undefined (AV_NOPTS_VALUE).
     * @note the ASF header does NOT contain a correct start_time the ASF
                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     * demuxer must NOT set this
     */
    int64_t start_time;

ffmpeg-dev is not a trashcan, please go and read the docs, ensure that your
patch meets the requirements (ABSOLUTELY 100% SURE that its the first pts
this is not true at all for asfs preroll field)


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070823/bdb56266/attachment.pgp>