[Ffmpeg-devel] [RFC] av_seek_frame behaviour

[Baptiste Coudurier]

Reimar D?ffinger a ?crit :
> Hello,
> On Sun, Apr 22, 2007 at 02:50:52AM +0200, Baptiste Coudurier wrote:
>>  I think about always returning after demuxer seek function, see patch.
>>  It might be wrong, and missed some demuxers behaviour.
> 
> This will most likely break seeking for gxf files without index.

Ouch, therefore problem is there for 10gb without index GXF files as 
well. Btw, it would be very much more efficient to seek on MEDIA packet 
for GXF, when no index is found.

> If anything, introduce two different return values, one indicating that
> the frame definitely is not there and another one to indicate that we
> should try the other seek methods.
> But that still will not fix your problem. From the description I'd say
> what you want is a FAST_SEEK_ONLY flag or similar that would only allow
> seek methods with O(log n) max. (which is another things that IMO is
> wrong with that patch, av_seek_frame_binary is O(log n), so except for
> streamed content there is not much reason to try that as well.

That has nothing to do with my patch, current code will always try 
av_seek_frame_binary if demuxer has read_timestamp and no seek function 
or if its seek function returned < 0.

What about calling av_seek_frame_generic only for formats having 
AVFMT_GENERIC_INDEX ?

[...]

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no