[Ffmpeg-devel] tiff encoder (qualification task for GSoC)

Michael Niedermayer michaelni
Tue Apr 3 15:44:41 CEST 2007


Hi

On Tue, Apr 03, 2007 at 11:09:15AM +0200, Bartlomiej Wolowiec wrote:
> On Tuesday 03 April 2007 03:07, Michael Niedermayer wrote:
> > > +/** sizes of various TIFF field types (string size = 100)*/
> > > +const uint8_t type_sizes[6] = {
> > > +    0, 1, 100, 2, 4, 8
> > >  };
> >
> > must have a ff_ prefix to avoid name clashes and the renaming of the
> > existing array should be a seperate patch (or leave the 12 bytes of
> > duplication ...)
> 
> Ok, I leave static type_sizes in tiff.h and add static type_sizes2 in 
> tiffenc.c...
> 
> > > +    strip_sizes = av_mallocz(4 * strips);
> > > +    strip_offsets = av_mallocz(4 * strips);
> >
> > s/4/sizeof(*strip_...)/
> >
> > [...]
> 
> done

patch applied

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct awnser.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070403/ec4c27ba/attachment.pgp>



More information about the ffmpeg-devel mailing list