[Ffmpeg-devel] tiff encoder (qualification task for GSoC)

[Bartlomiej Wolowiec]

On Tuesday 03 April 2007 03:07, Michael Niedermayer wrote:
> > +/** sizes of various TIFF field types (string size = 100)*/
> > +const uint8_t type_sizes[6] = {
> > +    0, 1, 100, 2, 4, 8
> >  };
>
> must have a ff_ prefix to avoid name clashes and the renaming of the
> existing array should be a seperate patch (or leave the 12 bytes of
> duplication ...)

Ok, I leave static type_sizes in tiff.h and add static type_sizes2 in 
tiffenc.c...

> > +    strip_sizes = av_mallocz(4 * strips);
> > +    strip_offsets = av_mallocz(4 * strips);
>
> s/4/sizeof(*strip_...)/
>
> [...]

done

Best Regards,
Bartek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tiff.patch
Type: text/x-diff
Size: 30969 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070403/8d265d5f/attachment.patch>