[PATCH] MPEG doxy comments (was Re: [Ffmpeg-devel] Motion Estimation in snow.c for Waevelet encoded frames (DWT))

Guillaume POIRIER poirierg
Sun Apr 1 00:41:14 CEST 2007


Hi,

On 4/1/07, Michael Niedermayer <michaelni at gmx.at> wrote:
> Hi
>
> On Sat, Mar 31, 2007 at 11:37:18PM +0200, Guillaume POIRIER wrote:
> > Hi,
> >
> > On 3/31/07, Michael Niedermayer <michaelni at gmx.at> wrote:
> > >Hi
> > >
> > >On Sat, Mar 31, 2007 at 11:06:45PM +0200, Guillaume POIRIER wrote:
> > >> Hi,
> > >> [..]
> > >>
> > >> I've put your explanations as Doxy comments.
> > >>
> > >> Is it worth making it to svn?
> > >
> > >definitly, see my comments below though
> > >[...]
> > >>      int pre_penalty_factor;
> > >> -    int penalty_factor;
> > >> +    int penalty_factor;                /*!< an estimate of the bits
> > >required to
> > >> +                                        code a given mv value, e.g.
> > >(1,0) takes
> > >> +                                        more bits than (0,0). We have to
> > >> +                                        estimate whether any reduction
> > >in
> > >> +                                        residual is worth the extra
> > >bits. */
> > >
> > >maybe clarify mv value vs. difference to predited mv ...
> >
> > Sure, no problem, but you'd have to provide me this explanation. I
> > don't know the different between both :-)
>
> hmm cant think of a good way to say it ATM :(
> so commit it as is its better than nothing

Ok, applied.

Guillaume


-- 
Rich, you're forgetting one thing here: *everybody* except you is
stupid.
    M?ns Rullg?rd



More information about the ffmpeg-devel mailing list