[PATCH] MPEG doxy comments (was Re: [Ffmpeg-devel] Motion Estimation in snow.c for Waevelet encoded frames (DWT))

Michael Niedermayer michaelni
Sun Apr 1 00:26:28 CEST 2007


Hi

On Sat, Mar 31, 2007 at 11:37:18PM +0200, Guillaume POIRIER wrote:
> Hi,
> 
> On 3/31/07, Michael Niedermayer <michaelni at gmx.at> wrote:
> >Hi
> >
> >On Sat, Mar 31, 2007 at 11:06:45PM +0200, Guillaume POIRIER wrote:
> >> Hi,
> >> [..]
> >>
> >> I've put your explanations as Doxy comments.
> >>
> >> Is it worth making it to svn?
> >
> >definitly, see my comments below though
> >[...]
> >>      int pre_penalty_factor;
> >> -    int penalty_factor;
> >> +    int penalty_factor;                /*!< an estimate of the bits 
> >required to
> >> +                                        code a given mv value, e.g. 
> >(1,0) takes
> >> +                                        more bits than (0,0). We have to
> >> +                                        estimate whether any reduction 
> >in
> >> +                                        residual is worth the extra 
> >bits. */
> >
> >maybe clarify mv value vs. difference to predited mv ...
> 
> Sure, no problem, but you'd have to provide me this explanation. I
> don't know the different between both :-)

hmm cant think of a good way to say it ATM :(
so commit it as is its better than nothing

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct awnser.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070401/b73c1d92/attachment.pgp>



More information about the ffmpeg-devel mailing list