[Ffmpeg-devel] [PATCH] Base64 code

[Michael Niedermayer]

Hi

On Fri, Oct 27, 2006 at 07:34:18PM -0500, Ryan Martell wrote:
> 
> On Oct 27, 2006, at 7:16 PM, Guillaume POIRIER wrote:
> 
> >Hi,
> >
> >On 10/28/06, Michael Niedermayer <michaelni at gmx.at> wrote:
> >>Hi
> >>
> >>On Fri, Oct 27, 2006 at 05:07:21PM -0500, Ryan Martell wrote:
> >>[...]
> >
> >>> smaller static code blocks are better.  Done. (although I let the
> >>> compiler count for me on the >79U part: sizeof(map2)/sizeof(map2 
> >>[0])).
> >>
> >>patch looks ok
> >
> >Compiles (with the same command line as for compiling http.c
> >Ryan, you need to provide a Makefile patch too, otherwise base64.* is
> >is just dead code.
> >
> >Anyway, patch applied, though I had to remove all trailing spaces and
> >fix licence header again. Please pay attention to those or else I just
> >won't spend the time to fix these issues for your and let someone else
> >apply it (yes, applying patches isn't hard, but it still takes time)
> 
> Sorry about that; I was copying the header from before it was updated  
> (I have lots of code I'm trying to get in).  I will check with vim  
> before submitting.
> 
> Here's the makefile patch, and the patch to http.c:



[...]
> @@ -203,7 +203,7 @@
>               hoststr,
>               auth_b64);
>  
> -    av_freep(&auth_b64);
> +    av_free(auth_b64);

why?


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is