[Ffmpeg-devel] [PATCH] Base64 code
Ryan Martell
rdm4
Sat Oct 28 02:34:18 CEST 2006
On Oct 27, 2006, at 7:16 PM, Guillaume POIRIER wrote:
> Hi,
>
> On 10/28/06, Michael Niedermayer <michaelni at gmx.at> wrote:
>> Hi
>>
>> On Fri, Oct 27, 2006 at 05:07:21PM -0500, Ryan Martell wrote:
>> [...]
>
>> > smaller static code blocks are better. Done. (although I let the
>> > compiler count for me on the >79U part: sizeof(map2)/sizeof(map2
>> [0])).
>>
>> patch looks ok
>
> Compiles (with the same command line as for compiling http.c
> Ryan, you need to provide a Makefile patch too, otherwise base64.* is
> is just dead code.
>
> Anyway, patch applied, though I had to remove all trailing spaces and
> fix licence header again. Please pay attention to those or else I just
> won't spend the time to fix these issues for your and let someone else
> apply it (yes, applying patches isn't hard, but it still takes time)
Sorry about that; I was copying the header from before it was updated
(I have lots of code I'm trying to get in). I will check with vim
before submitting.
Here's the makefile patch, and the patch to http.c:
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: base64patch.txt
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20061027/e6946743/attachment.txt>
-------------- next part --------------
More information about the ffmpeg-devel
mailing list