[Ffmpeg-devel] [PATCH] set MPEG 1/2 gop timecode frame start number

[Baptiste Coudurier]

Michael Niedermayer wrote:
>>> [...]
>>>
>>> ok and what is CODEC_FLAG2_DROP_FRAME_TIMECODE good for?
>>>
>>> cant that be either always false or set depending on framerate == 1001/30000?
>>>
>>> [...]
>> In practice, drop frame timecode should be used for NTSC 1001/30000
>> frame rate, but you can choose to use non drop frame timecode.
>>
>> 3 choices :
>> - non 1001/30000 (Im not sure about 1001/24000, maybe someone knows) :
>> non drop.
>> - 1001/30000: either drop or non drop, depends if you want real time
>> related time code
>>
>> I will add a check to force the use of 1001/30000 framerate index with
>> the flag, is it ok ?
> 
> no, the user app doesnt expect the codec to change things at will, if
> an invalid combination is used, print an error message explaining the issue
> and fail

Yes of course, that's what I meant.

> and except that patch ok
> 

Applied.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312