[Ffmpeg-devel] [PATCH] set MPEG 1/2 gop timecode frame start number

[Michael Niedermayer]

Hi

On Tue, Nov 07, 2006 at 12:01:48PM +0100, Baptiste Coudurier wrote:
> Hi
> 
> Michael Niedermayer wrote:
> > Hi
> > 
> > On Tue, Nov 07, 2006 at 12:29:43AM +0100, Baptiste Coudurier wrote:
> >> Michael Niedermayer wrote:
> >>> Hi
> >>>
> >>> On Mon, Nov 06, 2006 at 07:59:25PM +0100, Baptiste Coudurier wrote:
> >>>> Hi
> >>>>
> >>>> This patch add support to set MPEG 1/2 gop header timecode start. Also
> >>>> supports drop frame flag.
> >>> hmm, and what is that good for?
> >>>
> >> Setting a time code in gop headers. This will be detected as starting
> >> time of the media without interfering with pts.
> >> In broadcast environment, it can be really useful. It's simply a feature
> >> I would say.
> > 
> > ok and what is CODEC_FLAG2_DROP_FRAME_TIMECODE good for?
> > 
> > cant that be either always false or set depending on framerate == 1001/30000?
> > 
> > [...]
> 
> In practice, drop frame timecode should be used for NTSC 1001/30000
> frame rate, but you can choose to use non drop frame timecode.
> 
> 3 choices :
> - non 1001/30000 (Im not sure about 1001/24000, maybe someone knows) :
> non drop.
> - 1001/30000: either drop or non drop, depends if you want real time
> related time code
> 
> I will add a check to force the use of 1001/30000 framerate index with
> the flag, is it ok ?

no, the user app doesnt expect the codec to change things at will, if
an invalid combination is used, print an error message explaining the issue
and fail

and except that patch ok

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is