[Ffmpeg-devel] [PATCH] Cygwin vhook, always static avformat

[Måns Rullgård]

wzrlpy at arsystel.com writes:

> Hi,
>
> First of all, sorry to break the original thread, I needed to use another
> mail account, mplayerhq.hu is rejecting my mails from Hotmail.
> The original thread starts at
> http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2006-May/010821.html
>
> The objective of the patches is to make possible to compile vhook and
> shared libraries under Cygwin (currently the build of shared libraries is
> broken in this platform).
>
> Here is a link to the patch:
> http://usuarios.arsystel.com/wzrlpy/ffmpeg/ffmpeg.cygwin.vhook.3.patch
>
> After the patch is applied, the shared library compilation succeeds, but
> the resulting FFMpeg binary doesn't run, it crashes at startup.
> The reason is the way "loop_input" is defined, it is confusing
> Windows/Cygwin gcc/ldd.
>
> There was a patch for loop_input, submitted by Todd Kirby on 2005-06-05
> 07:48:03 GMT:
> http://news.gmane.org/find-root.php?message_id=%3c4b3e3180050605004865bb6dbd%40mail.gmail.com%3e
>
> I have adapted it to SVN-5646, and that avoids ffmpeg.exe crash at
> startup. It is here:
> http://usuarios.arsystel.com/wzrlpy/ffmpeg/ffmpeg.cygwin.loop_input.2.patch
>
> -----------------------------------------------
> Here is the ffmpeg.cygwin.vhook.3.patch file:
>
> diff -Naur ffmpeg-old/common.mak ffmpeg/common.mak
> --- ffmpeg-old/common.mak 2006-06-10 15:44:49.000000000 +0200
> +++ ffmpeg/common.mak 2006-07-07 20:52:14.250000000 +0200
> @@ -10,6 +10,13 @@
> LDFLAGS =

Malformed patch.

> -Wl,--output-def,$(@:.dll=.def),--out-implib,lib$(SLIBNAME:$(SLIBSUF)=.dll.a)
> endif
>
> +#FIXME: This should be in configure/config.mak

Rejected.  We will not accept new stuff with fixmes in it unless the
reason is much better (incomplete but usable codecs come to mind).

The rest looks awfully intrusive but the patch is mangled so I can't
read it.

-- 
M?ns Rullg?rd
mru at inprovide.com