[Ffmpeg-devel] PATCH: make libavformat find codecid for AACstreams in matroska container.

[elupus]

> -----Original Message-----
> From: Steve Lhomme [mailto:slhomme at divxcorp.com] 
> Sent: den 27 januari 2006 20:16
> To: FFMpeg development discussions and patches
> Subject: Re: [Ffmpeg-devel] PATCH: make libavformat find 
> codecid for AACstreams in matroska container.
> 
> elupus wrote:
> > Hi, 
> > 
> > Here is a small patch to allow libavformat to find the 
> codec on AAC streams
> > in matroska containers. 
> > 
> > The defines for the AAC codec's are set like this, 
> > 
> > 	#define MATROSKA_CODEC_ID_AUDIO_MPEG2        "A_AAC/MPEG2/"
> > 	#define MATROSKA_CODEC_ID_AUDIO_MPEG4        "A_AAC/MPEG4/"
> > 
> > which isn't the full name for the codec's. I.e. it normally 
> has some more
> > extension to it like MAIN, LC... 
> > 
> > Anyway, this patch fixes so that when the codec_id is 
> compared to these
> > defines, only the given length is compared (which I think 
> was the original
> > idea). I suppose some more information could be gotten from 
> that extra
> > information, but I think this should be enough.
> > 
> > Cheers
> > 
> > /Joakim
> 
> I provided a patch that handles this and the codec private 
> and also the 
> new and simple A_AAC (everything is said in the codec 
> private). But the 
> patch was rejected (although factorizing that code means having FAAD 
> support which is GPL).
> 
> You can find the code in the source releases of DrFFMPEG on 
> SourceForge.
> 
> 
> 

Took the liberty of finding this patch.. Stripped some of the compiler
warning / int64 fixes away and I've not tried to compile it right now. Just
a RFC for now.

/Joakim
-------------- next part --------------
A non-text attachment was scrubbed...
Name: matroska.c.patch
Type: application/octet-stream
Size: 8173 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060127/adc8f10a/attachment.obj>