[Ffmpeg-devel] Re: [PATCH] mov fps fix

[Michael Niedermayer]

Hi

On Tue, Jan 17, 2006 at 02:35:41PM +0100, Baptiste COUDURIER wrote:
[...]
> >>I did not get point 3, did you mean all "stts" samples durations ?
> > 
> > 
> > yes gcd(duration1, duration2, ..., durationN)
> > 
> 
> Maybe, checking the last user question about fps in MOV. His file,
> test01.mov had this specifications :
> 
> stts atom:
>        count 10576 duration 24
>        count 1 duration 86
> 
> while timescale is 600.
> 
> Obviously frame rate is 25. But because of that last sample, it cannot
> be computed right. Do you have any idea ?

if what you write is correct then the timebase for this file is 1/300
1/25 is wrong


> 
> > [...]
> > 
> > could you add a assert() here to ensure that the conversation is exact? i 
> > know it should be exact but better double check to catch (future) bugs quickly
> > 
> > [...]
> > 
> 
> Sorry for being dumb, but I cannot see which "conversation" you are
> talking about :/

every av_rescale() must have zero remainder / be exact

[...]
-- 
Michael