[Ffmpeg-devel] [PATCH] Fixes for Darwin/x86

[Michael Niedermayer]

Hi

On Tue, Feb 07, 2006 at 01:29:31PM +0100, Dan Villiom Podlaski Christiansen wrote:
> On 07/02/2006, at 12.52, Michael Niedermayer wrote:
> 
> >Hi
> >
> >On Tue, Feb 07, 2006 at 12:05:32PM +0100, Dan Villiom Podlaski  
> >Christiansen wrote:
> >>>*ALIGN* isnt mmx specific so doesnt belong in mmx.h
> >>
> >>However, AFAICT it is only used in code that requires MMX. Which
> >>header would you rather have it in?
> >
> >dsputil.h, its not even x86 specific!
> 
> Very well. Is this acceptable?
> 
> While at it, I made a minor change in the way PIC is defined on Darwin.

how is this related to the align stuff? this should be a seperate patch ...


> --- libavcodec/i386/dsputil_mmx_rnd.h   12 Jan 2006 22:43:17 -0000      1.22
> +++ libavcodec/i386/dsputil_mmx_rnd.h   7 Feb 2006 12:28:06 -0000
> @@ -22,13 +22,15 @@
>   * and improved by Zdenek Kabelac <kabi at users.sf.net>
>   */
> 
> +#include "mmx.h"
> +

why?

and the whitespace change i already complained about is still in there

[...]

-- 
Michael