[Ffmpeg-devel] [PATCH] Fixes for Darwin/x86

Dan Villiom Podlaski Christiansen danchr
Wed Feb 8 09:09:36 CET 2006


On 08/02/2006, at 1.38, Michael Niedermayer wrote:

>> While at it, I made a minor change in the way PIC is defined on  
>> Darwin.
>
> how is this related to the align stuff? this should be a seperate  
> patch ...

It is related to getting the i386 parts compiling on Darwin/x86. Only  
the x86-specific code checks whether PIC is defined, so there has  
been no need to define it until now. This is a necessary fix for  
getting dynamic builds working on Darwin/x86, although it's not enough.

>> --- libavcodec/i386/dsputil_mmx_rnd.h   12 Jan 2006 22:43:17  
>> -0000      1.22
>> +++ libavcodec/i386/dsputil_mmx_rnd.h   7 Feb 2006 12:28:06 -0000
>> @@ -22,13 +22,15 @@
>>   * and improved by Zdenek Kabelac <kabi at users.sf.net>
>>   */
>>
>> +#include "mmx.h"
>> +
>
> why?

Leftover from when the ALIGN macros where in mmx.h. Removed.

> and the whitespace change i already complained about is still in there

Removed.

--

- Dan Villiom Podlaski Christiansen

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg-darwin-i386-fixes.diff
Type: application/applefile
Size: 387 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060208/96d7fc31/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg-darwin-i386-fixes.diff
Type: application/octet-stream
Size: 25722 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060208/96d7fc31/attachment.obj>
-------------- next part --------------





More information about the ffmpeg-devel mailing list