[Ffmpeg-devel] Re: r7354 - trunk/configure

[sci-fi at hush.ai]

On 2006-12-22 16:20:16 -0600, Diego Biurrun <diego at biurrun.de> said:

> On Fri, Dec 22, 2006 at 01:42:07AM -0600, sci-fi at hush.ai wrote:
>> On 2006-12-21 23:20:47 -0600, diego <subversion at mplayerhq.hu> said:
>> 
>>> Log:
>>> Fix linking on Intel Mac due to local relocation entries in
>>> non-writable sections.
>>> patch by Tom Harper d.thomas.harper gmail com
>>> 
>>> --- trunk/configure	(original)
>>> +++ trunk/configure	Fri Dec 22 06:20:47 2006
>>> @@ -753,7 +753,7 @@
>>> audio_oss="no"
>>> dv1394="no"
>>> need_memalign="no"
>>> -SHFLAGS="-dynamiclib -Wl,-single_module 
>>> -Wl,-install_name,\$(shlibdir)/\$(SLIBNAME),-current_version,\$(SPPVERSION),-compatibility_version,\$(SPPVERSION)"
+SHFLAGS="-dynamiclib

-Wl,-single_module 
>>> 
>>> -Wl,-install_name,\$(shlibdir)/\$(SLIBNAME),-current_version,\$(SPPVERSION),-compatibility_version,\$(SPPVERSION) 
>>> -read_only_relocs suppress"
>> 
>> I say again: this should be prefixed with -Wl as the rest of the linker
>> flags there-in on the same line are done, e.g. do SHFLAGS this way:
>> 
>> +SHFLAGS="-dynamiclib -Wl,-single_module 
>> -Wl,-install_name,\$(shlibdir)/\$(SLIBNAME),-current_version,\$(SPPVERSION),-compatibility_version,\$(SPPVERSION) 
>> -Wl,-read_only_relocs,suppress"
> 
> Whatever makes you happy, changed ..
> 
> Diego

thank you

i _do_ try ...


--