[PATCH] Re: [Ffmpeg-devel] RealAudio 14.4

Roberto Togni r_togni
Thu Dec 15 00:09:47 CET 2005

On Tue, 13 Dec 2005 12:50:38 +0000
mkhodor7 at yahoo.com wrote:

> Roberto Togni wrote:
> > I'll check and eventually apply it tomorrow, but i think that most of
> > this is unneeded (just check length before reading fourcc, and decide
> > if file have: nothing, fourcc only, fourcc + extra crap to be skipped).
> > 
> > Do you have any sample where some things other than fourcc are missing?
> > 
> > Ciao,
> >  Roberto
> > 
> No... BTW, Actual RealPlayer ignores the fourcc in these files.  I'm 
> guessing they left themselves room for future expansion, but never
> used it, instead they redid the file format in the next version.  So
> the fourcc is really just 'extra crap to be skipped'.

Sorry for delay. Please test attached patch.

A few notes:
- the "skip other header crap" is not really needed for any sample i
- the fourcc read could be replaced by a 5 byte skip for every known
sample that have fourcc
- the buffer size was increased for correctness only (max string len
is 255), not for safety (str_8() can't overflow the buffer). No known
samples have long strings anyway.

I plan to apply this no later than this weekend.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: rmthank.diff
Type: text/x-patch
Size: 1370 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20051215/ea5f0667/attachment.bin>

More information about the ffmpeg-devel mailing list