[Ffmpeg-devel] MPEGTS PID specification (was question on subm itting changes) ...

[Brown, Mike]

M?ns,

Would the following approach for over-riding ffmpeg's default PIDs be
acceptable?

Add two "advanced video" command line options to specify new values to over
ride the existing default values of DEFAULT_PMT_START_PID   0x1000 &
DEFAULT_START_PID       0x0100.

For example:
     ffmpeg <other options> -mpegts_pmtstartpid=0x10a0
-mpegts_startpid=0x10c0

If these command line options are not used then the existing default values
continue to be used.

Regards,
Mike Brown



-----Original Message-----
From: M?ns Rullg?rd [mailto:mru at inprovide.com]
Sent: Thursday, August 11, 2005 4:11 AM
To: FFMpeg development discussions and patches
Subject: Re: [Ffmpeg-devel] question on submitting changes ...



Brown, Mike said:
> I've made a small change to ffmpeg to allow ffmpeg to process Microsoft
WMV
> format files that contain script streams (aka command media).  This change
> allows the files to be processed but ignores the script stream.
>
> I'm new to ffmpeg and since the mplayer docs are offline I don't have
> information on the details of submitting changes back to ffmpeg.  If this
> functionality is of interest would someone let me know the procedure for
> submitting the changes?

Run "cvs diff -u", and post the output to the mailing list as an attachment.

> In addition, I've changed the default MPEG TS PIDs for a particular
> application.  The mailing list archive has a couple of messages from
another
> person asking about adding logic to support the ability change PIDs from
the
> command line.  Is there interest in adding this functionality or should I
> continue to modify the constants in the source?

Anything that depends on specific PIDs being used for audio or video is
broken, IMHO.  That said, if there is a clean way of implementing PID
selection, I'd be OK with adding that.

-- 
M?ns Rullg?rd
mru at inprovide.com

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel at mplayerhq.hu
http://mplayerhq.hu/mailman/listinfo/ffmpeg-devel