[FFmpeg-cvslog] avcodec/x86/synth_filter: Remove obsolete SSE function

Andreas Rheinhardt git at videolan.org
Wed Jun 22 15:29:40 EEST 2022


ffmpeg | branch: master | Andreas Rheinhardt <andreas.rheinhardt at outlook.com> | Tue Jun 14 20:31:03 2022 +0200| [eb33fd384e70900644b5c1a06e266819af32b02e] | committer: Andreas Rheinhardt

avcodec/x86/synth_filter: Remove obsolete SSE function

The only systems which benefit from synth_filter_sse are truely
ancient 32bit x86s as all other systems use at least the SSE2 versions
(this includes all x64 cpus (which is why this code is restricted
to x86-32)).

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=eb33fd384e70900644b5c1a06e266819af32b02e
---

 libavcodec/x86/synth_filter.asm    | 6 +-----
 libavcodec/x86/synth_filter_init.c | 8 --------
 2 files changed, 1 insertion(+), 13 deletions(-)

diff --git a/libavcodec/x86/synth_filter.asm b/libavcodec/x86/synth_filter.asm
index bc1a48f409..22f57c3309 100644
--- a/libavcodec/x86/synth_filter.asm
+++ b/libavcodec/x86/synth_filter.asm
@@ -115,7 +115,7 @@ cglobal synth_filter_inner, 0, 6 + 4 * ARCH_X86_64, 7 + 6 * ARCH_X86_64, \
                               synth_buf, synth_buf2, window, out, off, scale
 %define scale m0
 %if ARCH_X86_32 || WIN64
-%if cpuflag(sse2) && notcpuflag(avx)
+%if notcpuflag(avx)
     movd       scale, scalem
     SPLATD        m0
 %else
@@ -234,10 +234,6 @@ cglobal synth_filter_inner, 0, 6 + 4 * ARCH_X86_64, 7 + 6 * ARCH_X86_64, \
     RET
 %endmacro
 
-%if ARCH_X86_32
-INIT_XMM sse
-SYNTH_FILTER
-%endif
 INIT_XMM sse2
 SYNTH_FILTER
 INIT_YMM avx
diff --git a/libavcodec/x86/synth_filter_init.c b/libavcodec/x86/synth_filter_init.c
index 35e2b47a3e..7c76ac8d05 100644
--- a/libavcodec/x86/synth_filter_init.c
+++ b/libavcodec/x86/synth_filter_init.c
@@ -43,9 +43,6 @@ static void synth_filter_##opt(FFTContext *imdct,                              \
 }                                                                              \
 
 #if HAVE_X86ASM
-#if ARCH_X86_32
-SYNTH_FILTER_FUNC(sse)
-#endif
 SYNTH_FILTER_FUNC(sse2)
 SYNTH_FILTER_FUNC(avx)
 SYNTH_FILTER_FUNC(fma3)
@@ -56,11 +53,6 @@ av_cold void ff_synth_filter_init_x86(SynthFilterContext *s)
 #if HAVE_X86ASM
     int cpu_flags = av_get_cpu_flags();
 
-#if ARCH_X86_32
-    if (EXTERNAL_SSE(cpu_flags)) {
-        s->synth_filter_float = synth_filter_sse;
-    }
-#endif
     if (EXTERNAL_SSE2(cpu_flags)) {
         s->synth_filter_float = synth_filter_sse2;
     }



More information about the ffmpeg-cvslog mailing list