[FFmpeg-cvslog] avcodec/x86/dct32: Remove obsolete SSE function

Andreas Rheinhardt git at videolan.org
Wed Jun 22 15:29:38 EEST 2022


ffmpeg | branch: master | Andreas Rheinhardt <andreas.rheinhardt at outlook.com> | Tue Jun 14 20:26:16 2022 +0200| [54784ffac523c6fbc50762a91b3dcc481933b0b0] | committer: Andreas Rheinhardt

avcodec/x86/dct32: Remove obsolete SSE function

The only systems which benefit from ff_dct32_float_sse are truely
ancient 32bit x86s as all other systems use at least the SSE2 versions
(this includes all x64 cpus (which is why this code is restricted
to x86-32)).

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=54784ffac523c6fbc50762a91b3dcc481933b0b0
---

 libavcodec/x86/dct32.asm  | 12 +-----------
 libavcodec/x86/dct_init.c |  5 -----
 2 files changed, 1 insertion(+), 16 deletions(-)

diff --git a/libavcodec/x86/dct32.asm b/libavcodec/x86/dct32.asm
index 21e2f21c97..37fba51543 100644
--- a/libavcodec/x86/dct32.asm
+++ b/libavcodec/x86/dct32.asm
@@ -387,7 +387,7 @@ INIT_XMM
 %endif
 
 
-; void ff_dct32_float_sse(FFTSample *out, const FFTSample *in)
+; void ff_dct32_float(FFTSample *out, const FFTSample *in)
 %macro DCT32_FUNC 0
 cglobal dct32_float, 2, 3, 16, out, in, tmp
     ; pass 1
@@ -474,18 +474,8 @@ cglobal dct32_float, 2, 3, 16, out, in, tmp
 %endmacro
 
 %macro LOAD_INV 2
-%if cpuflag(sse2)
     pshufd      %1, %2, 0x1b
-%elif cpuflag(sse)
-    movaps      %1, %2
-    shufps      %1, %1, 0x1b
-%endif
 %endmacro
 
-%if ARCH_X86_32
-INIT_XMM sse
-DCT32_FUNC
-%endif
-
 INIT_XMM sse2
 DCT32_FUNC
diff --git a/libavcodec/x86/dct_init.c b/libavcodec/x86/dct_init.c
index c31ef92238..d0e4b34dd3 100644
--- a/libavcodec/x86/dct_init.c
+++ b/libavcodec/x86/dct_init.c
@@ -22,7 +22,6 @@
 #include "libavutil/x86/cpu.h"
 #include "libavcodec/dct.h"
 
-void ff_dct32_float_sse(FFTSample *out, const FFTSample *in);
 void ff_dct32_float_sse2(FFTSample *out, const FFTSample *in);
 void ff_dct32_float_avx(FFTSample *out, const FFTSample *in);
 
@@ -30,10 +29,6 @@ av_cold void ff_dct_init_x86(DCTContext *s)
 {
     int cpu_flags = av_get_cpu_flags();
 
-#if ARCH_X86_32
-    if (EXTERNAL_SSE(cpu_flags))
-        s->dct32 = ff_dct32_float_sse;
-#endif
     if (EXTERNAL_SSE2(cpu_flags))
         s->dct32 = ff_dct32_float_sse2;
     if (EXTERNAL_AVX_FAST(cpu_flags))



More information about the ffmpeg-cvslog mailing list