[FFmpeg-cvslog] r26302 - trunk/libavformat/electronicarts.c

[Michael Niedermayer]

On Mon, Jan 10, 2011 at 02:46:02PM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Mon, Jan 10, 2011 at 2:38 PM, Stefano Sabatini
> <stefano.sabatini-lala at poste.it> wrote:
> > On date Monday 2011-01-10 14:10:23 -0500, Ronald S. Bultje wrote:
> >> On Mon, Jan 10, 2011 at 7:56 AM, pross <subversion at mplayerhq.hu> wrote:
> >> > Author: pross
> >> > Date: Mon Jan 10 13:56:50 2011
> >> > New Revision: 26302
> >> >
> >> > Log:
> >> > electronicarts: prevent endless loop opportunity in process_audio_header_elements()
> >> > Fixes issue2529.
> > [...]
> >> This seems to have broken FATE, or one of the previous commits in this
> >> file. You do run make fate after every change, right?
> >
> > I believe it's OK not to require devels to "make fate" at every
> > change
> 
> Macintosh-10:x86-64 ronaldbultje$ make fate-list|grep ea|grep adpcm
> fate-adpcm-ea-r2
> fate-adpcm-ea-r3
> fate-creative-adpcm
> fate-creative-adpcm-8-2.6bit
> fate-creative-adpcm-8-2bit
> fate-creative-adpcm-8-4bit
> fate-ea-mad-adpcm-ea-r1
> fate-ea-tqi-adpcm
> 
> No that's not OK, it's pure laziness. Just run the individual tests if
> your time is really this precious. I have to go hunting which commit
> likely broke fate every day now. This costs ME way too mcuh time.

i think that for some commits like editing comments its ok not to
run fate



[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you think the mosad wants you dead since a long time then you are either
wrong or dead since a long time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20110111/5f7abc7e/attachment.pgp>