[FFmpeg-cvslog] r26302 - trunk/libavformat/electronicarts.c

[Ronald S. Bultje]

Hi,

On Mon, Jan 10, 2011 at 2:38 PM, Stefano Sabatini
<stefano.sabatini-lala at poste.it> wrote:
> On date Monday 2011-01-10 14:10:23 -0500, Ronald S. Bultje wrote:
>> On Mon, Jan 10, 2011 at 7:56 AM, pross <subversion at mplayerhq.hu> wrote:
>> > Author: pross
>> > Date: Mon Jan 10 13:56:50 2011
>> > New Revision: 26302
>> >
>> > Log:
>> > electronicarts: prevent endless loop opportunity in process_audio_header_elements()
>> > Fixes issue2529.
> [...]
>> This seems to have broken FATE, or one of the previous commits in this
>> file. You do run make fate after every change, right?
>
> I believe it's OK not to require devels to "make fate" at every
> change

Macintosh-10:x86-64 ronaldbultje$ make fate-list|grep ea|grep adpcm
fate-adpcm-ea-r2
fate-adpcm-ea-r3
fate-creative-adpcm
fate-creative-adpcm-8-2.6bit
fate-creative-adpcm-8-2bit
fate-creative-adpcm-8-4bit
fate-ea-mad-adpcm-ea-r1
fate-ea-tqi-adpcm

No that's not OK, it's pure laziness. Just run the individual tests if
your time is really this precious. I have to go hunting which commit
likely broke fate every day now. This costs ME way too mcuh time.

Ronald