[FFmpeg-cvslog] r25385 - trunk/libavformat/mpegenc.c

[Diego Biurrun]

On Fri, Oct 08, 2010 at 05:28:09PM +0200, Michael Niedermayer wrote:
> On Fri, Oct 08, 2010 at 11:08:03AM +0200, Diego Biurrun wrote:
> > On Thu, Oct 07, 2010 at 08:33:19PM +0200, Michael Niedermayer wrote:
> > > On Thu, Oct 07, 2010 at 02:17:10PM +0200, Diego Biurrun wrote:
> > > > On Thu, Oct 07, 2010 at 12:24:15PM +0200, Michael Niedermayer wrote:
> > > > > On Wed, Oct 06, 2010 at 08:16:20PM -0700, Alex Converse wrote:
> > > > > > On Wed, Oct 6, 2010 at 6:57 PM, michael <subversion at mplayerhq.hu> wrote:
> > > > > > >
> > > > > > > Log:
> > > > > > > Warn if muxing mpeg ps is attempted without a VBV buffer size.
> > > > > > >
> > > > > > > --- trunk/libavformat/mpegenc.c Thu Oct ?7 03:57:35 2010 ? ? ? ?(r25384)
> > > > > > > +++ trunk/libavformat/mpegenc.c Thu Oct ?7 03:57:39 2010 ? ? ? ?(r25385)
> > > > > > > @@ -367,8 +367,10 @@ static int mpeg_mux_init(AVFormatContext
> > > > > > > ? ? ? ? ? ? if (st->codec->rc_buffer_size)
> > > > > > > ? ? ? ? ? ? ? ? stream->max_buffer_size = 6*1024 + st->codec->rc_buffer_size/8;
> > > > > > > - ? ? ? ? ? ?else
> > > > > > > + ? ? ? ? ? ?else{
> > > > > > 
> > > > > > Just two days ago people asked you to put whitespace after keywords.
> > > > > 
> > > > > yes and iam not doing it, you should vote on me being leader accordingly.
> > > > 
> > > > The attitude you show when criticized...
> > > > 
> > > > > also IMHO, the one who said it loud enough for me to remember it at all is
> > > > > diego (on the phone ;) ) and he
> > > > > neither maintains C code nor is he contributing C code. And this is stuff
> > > > > that should be decided by the people falling in these 2 categories
> > > > 
> > > > Except of course for Stefano two days ago.  And who would dare to
> > > > criticize you when you immediately threaten to kill the critic or
> > > > yourself?
> > > 
> > > killing myself is my choice ;)
> > > and i didnt threten to kill any critic
> > 
> > Correct.  You skip the threats and proceed to kill them.
> 
> do you have an example?

dead bodies litter the trail you leave behind yourself ;)

> The strict K&R style is a recent trend that was started by uoti in mplayer
> before he was thrown out

Nonsense.

> > > And the other part (not part of the policy) about style says that:
> > >     Indent size is 4.
> > >     The presentation is one inspired by 'indent -i4 -kr -nut'.
> > >     The TAB character is forbidden outside of Makefiles as is any
> > >     form of trailing whitespace. Commits containing either will be
> > >     rejected by the Subversion repository.
> > > 
> > > This says 'INSPIRED by 'indent -i4 -kr -nut'' it does not say follow the
> > > indent output to the last whitespace is mandatory
> > 
> > The "inspired" is a change unilaterally approved by yourself.
> 
> It was a patch by ben posted to ffmpeg-dev that added "inspired", and noone
> expressed any dislike for this change until now, the mail from ben is below as
> reference.

I know.

Diego